Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Linux disk encryption status in configuration profiles aggregate status response when applicable #24114

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Nov 23, 2024

Addresses #24112

Counts included:
Screenshot 2024-11-22 at 5 31 06 PM

  • Include counts when disk encryption is enforced
  • Exclude counts when disk encryption isn't enforced
    __
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 17.77778% with 37 lines in your changes missing coverage. Please review.

Project coverage is 54.08%. Comparing base (ee73249) to head (986d069).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/service/linux_mdm.go 0.00% 19 Missing ⚠️
server/service/mdm.go 0.00% 8 Missing ⚠️
ee/server/service/teams.go 20.00% 4 Missing ⚠️
server/service/apple_mdm.go 20.00% 4 Missing ⚠️
frontend/services/entities/mdm.ts 0.00% 1 Missing ⚠️
server/datastore/mysql/labels.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24114      +/-   ##
==========================================
- Coverage   63.42%   54.08%   -9.34%     
==========================================
  Files        1579     1579              
  Lines      149948   150068     +120     
  Branches     3818     3818              
==========================================
- Hits        95106    81166   -13940     
- Misses      47261    62183   +14922     
+ Partials     7581     6719     -862     
Flag Coverage Δ
backend 54.11% <18.18%> (-10.19%) ⬇️
frontend 52.54% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

server/fleet/service.go Outdated Show resolved Hide resolved
server/service/linux_mdm.go Outdated Show resolved Hide resolved
@iansltx iansltx changed the title Aggregate status missing linux Include Linux disk encryption status in configuration profiles aggregate status response when applicable Nov 23, 2024
@iansltx
Copy link
Member

iansltx commented Nov 23, 2024

Merging in my existing integration tests branch here as I need the integration test started there to confirm this is behaving correctly. Will probably expand PR scope for the other config known issue(s).

@iansltx iansltx force-pushed the aggregate-status-missing-linux branch from ad30999 to 1a716f5 Compare November 23, 2024 02:46
@iansltx iansltx marked this pull request as ready for review November 23, 2024 02:51
@iansltx iansltx requested review from a team as code owners November 23, 2024 02:51
…urned on, skip FileVault config when enabling disk encryption when macOS MDM is off

Also ensures disk encryption on a per-team basis works as expected.

TODO: set up FileVault if Mac MDM gets enabled after encryption enforcement is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants